Rework template assets to use variables instead of component specific param lists #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
template_variables
branch
from
3e23580
to
ab3967a
Compare
rowanseymour
commented
Apr 12, 2024
| { | ||
| "type": "image" | ||
| } | ||
| ] |
There was a problem hiding this comment.
stripping this out because we don't support anything besides text
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
- Coverage 82.50% 82.49% -0.02%
==========================================
Files 279 279
Lines 14453 14458 +5
==========================================
+ Hits 11925 11927 +2
- Misses 2025 2028 +3
Partials 503 503 ☔ View full report in Codecov by Sentry. |
norkans7
reviewed
Apr 13, 2024
| if i < len(paramValues) { | ||
| params[i] = flows.TemplatingParam{Type: p.Type(), Value: paramValues[i]} | ||
| params[i] = flows.TemplatingParam{Type: v.Type(), Value: paramValues[i]} |
There was a problem hiding this comment.
Any reason to not add varName in the TemplatingParam?
That is the new data we need to be able to support the Twilio templates which triggered this refactoring.
I guess that could be another PR too if this is just for backward compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.